Fix: RangeSlider progress fill does not update its width on window resize of plugin #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added a null check for inputElement in renderProgressTrack to prevent errors if the element isn't mounted yet. 2. Added a new useEffect that listens for window `resize` events and recalculates the progress track when the window is resized. 3. Proper cleanup - the resize listener is removed when the component unmounts
Refactor resize handling in range slider component.
Jeremy-Knudsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposed fix to the following issue: RangeSlider progress fill does not update its width on window resize of plugin
The fix entails the following: