Skip to content

fix: remove numcodecs off-spec warning#3833

Merged
d-v-b merged 5 commits intozarr-developers:mainfrom
slevang:numcodecs-warn
Mar 27, 2026
Merged

fix: remove numcodecs off-spec warning#3833
d-v-b merged 5 commits intozarr-developers:mainfrom
slevang:numcodecs-warn

Conversation

@slevang
Copy link
Copy Markdown
Contributor

@slevang slevang commented Mar 25, 2026

Closes #3832.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Mar 25, 2026
"may not be supported by other zarr implementations.",
category=ZarrUserWarning,
stacklevel=2,
)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d-v-b - what do think about dropping this warning all together now?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could drop it!

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done. This seems reasonable to me, and makes the assumption that any future breaking changes will at least maintain read compatibility for previously written data. Which is good UX.

@slevang slevang changed the title fix: numcodecs only warn on write fix: remove numcodecs off-spec warning Mar 25, 2026
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Mar 25, 2026
@d-v-b d-v-b enabled auto-merge (squash) March 27, 2026 19:08
@d-v-b d-v-b merged commit 19a383f into zarr-developers:main Mar 27, 2026
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

numcodecs warn on read

3 participants