Handle the case the info response does not contains endpoints / empty#10838
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~f3f3ae9206, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1068771
Total [baseline] (11.143 s) : 0, 11142609
Agent [candidate] (1.06 s) : 0, 1060450
Total [candidate] (10.975 s) : 0, 10974903
section appsec
Agent [baseline] (1.245 s) : 0, 1244838
Total [baseline] (11.185 s) : 0, 11184591
Agent [candidate] (1.252 s) : 0, 1252475
Total [candidate] (11.076 s) : 0, 11076012
section iast
Agent [baseline] (1.237 s) : 0, 1237277
Total [baseline] (11.345 s) : 0, 11344657
Agent [candidate] (1.226 s) : 0, 1226275
Total [candidate] (11.389 s) : 0, 11389111
section profiling
Agent [baseline] (1.18 s) : 0, 1180354
Total [baseline] (11.042 s) : 0, 11041696
Agent [candidate] (1.181 s) : 0, 1181079
Total [candidate] (11.01 s) : 0, 11010351
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~f3f3ae9206, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.214 ms) : 0, 1214
crashtracking [candidate] (1.188 ms) : 0, 1188
BytebuddyAgent [baseline] (633.451 ms) : 0, 633451
BytebuddyAgent [candidate] (627.587 ms) : 0, 627587
AgentMeter [baseline] (29.453 ms) : 0, 29453
AgentMeter [candidate] (29.133 ms) : 0, 29133
GlobalTracer [baseline] (258.738 ms) : 0, 258738
GlobalTracer [candidate] (256.436 ms) : 0, 256436
AppSec [baseline] (31.752 ms) : 0, 31752
AppSec [candidate] (31.386 ms) : 0, 31386
Debugger [baseline] (59.794 ms) : 0, 59794
Debugger [candidate] (59.343 ms) : 0, 59343
Remote Config [baseline] (635.752 µs) : 0, 636
Remote Config [candidate] (618.125 µs) : 0, 618
Telemetry [baseline] (8.701 ms) : 0, 8701
Telemetry [candidate] (8.594 ms) : 0, 8594
Flare Poller [baseline] (8.774 ms) : 0, 8774
Flare Poller [candidate] (10.182 ms) : 0, 10182
section appsec
crashtracking [baseline] (1.193 ms) : 0, 1193
crashtracking [candidate] (1.196 ms) : 0, 1196
BytebuddyAgent [baseline] (657.156 ms) : 0, 657156
BytebuddyAgent [candidate] (661.872 ms) : 0, 661872
AgentMeter [baseline] (12.062 ms) : 0, 12062
AgentMeter [candidate] (12.144 ms) : 0, 12144
GlobalTracer [baseline] (257.697 ms) : 0, 257697
GlobalTracer [candidate] (259.192 ms) : 0, 259192
AppSec [baseline] (177.263 ms) : 0, 177263
AppSec [candidate] (178.001 ms) : 0, 178001
Debugger [baseline] (66.097 ms) : 0, 66097
Debugger [candidate] (66.201 ms) : 0, 66201
Remote Config [baseline] (566.847 µs) : 0, 567
Remote Config [candidate] (577.974 µs) : 0, 578
Telemetry [baseline] (8.935 ms) : 0, 8935
Telemetry [candidate] (9.126 ms) : 0, 9126
Flare Poller [baseline] (3.648 ms) : 0, 3648
Flare Poller [candidate] (3.708 ms) : 0, 3708
IAST [baseline] (23.992 ms) : 0, 23992
IAST [candidate] (24.152 ms) : 0, 24152
section iast
crashtracking [baseline] (1.211 ms) : 0, 1211
crashtracking [candidate] (1.208 ms) : 0, 1208
BytebuddyAgent [baseline] (802.2 ms) : 0, 802200
BytebuddyAgent [candidate] (795.401 ms) : 0, 795401
AgentMeter [baseline] (11.596 ms) : 0, 11596
AgentMeter [candidate] (11.341 ms) : 0, 11341
GlobalTracer [baseline] (248.796 ms) : 0, 248796
GlobalTracer [candidate] (247.258 ms) : 0, 247258
AppSec [baseline] (26.758 ms) : 0, 26758
AppSec [candidate] (26.441 ms) : 0, 26441
Debugger [baseline] (65.27 ms) : 0, 65270
Debugger [candidate] (64.689 ms) : 0, 64689
Remote Config [baseline] (526.676 µs) : 0, 527
Remote Config [candidate] (521.837 µs) : 0, 522
Telemetry [baseline] (14.488 ms) : 0, 14488
Telemetry [candidate] (13.723 ms) : 0, 13723
Flare Poller [baseline] (4.783 ms) : 0, 4783
Flare Poller [candidate] (4.576 ms) : 0, 4576
IAST [baseline] (25.41 ms) : 0, 25410
IAST [candidate] (25.118 ms) : 0, 25118
section profiling
ProfilingAgent [baseline] (93.873 ms) : 0, 93873
ProfilingAgent [candidate] (93.324 ms) : 0, 93324
crashtracking [baseline] (1.165 ms) : 0, 1165
crashtracking [candidate] (1.169 ms) : 0, 1169
BytebuddyAgent [baseline] (681.416 ms) : 0, 681416
BytebuddyAgent [candidate] (682.213 ms) : 0, 682213
AgentMeter [baseline] (8.642 ms) : 0, 8642
AgentMeter [candidate] (8.669 ms) : 0, 8669
GlobalTracer [baseline] (215.35 ms) : 0, 215350
GlobalTracer [candidate] (215.23 ms) : 0, 215230
AppSec [baseline] (31.881 ms) : 0, 31881
AppSec [candidate] (31.931 ms) : 0, 31931
Debugger [baseline] (63.489 ms) : 0, 63489
Debugger [candidate] (63.129 ms) : 0, 63129
Remote Config [baseline] (584.807 µs) : 0, 585
Remote Config [candidate] (587.195 µs) : 0, 587
Telemetry [baseline] (9.784 ms) : 0, 9784
Telemetry [candidate] (10.547 ms) : 0, 10547
Flare Poller [baseline] (3.454 ms) : 0, 3454
Flare Poller [candidate] (3.52 ms) : 0, 3520
Profiling [baseline] (94.446 ms) : 0, 94446
Profiling [candidate] (93.889 ms) : 0, 93889
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~f3f3ae9206, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1067313
Total [baseline] (8.849 s) : 0, 8849486
Agent [candidate] (1.058 s) : 0, 1058140
Total [candidate] (8.812 s) : 0, 8812362
section iast
Agent [baseline] (1.225 s) : 0, 1224898
Total [baseline] (9.552 s) : 0, 9551731
Agent [candidate] (1.229 s) : 0, 1228950
Total [candidate] (9.601 s) : 0, 9601300
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~f3f3ae9206, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.191 ms) : 0, 1191
BytebuddyAgent [baseline] (633.525 ms) : 0, 633525
BytebuddyAgent [candidate] (627.374 ms) : 0, 627374
AgentMeter [baseline] (29.33 ms) : 0, 29330
AgentMeter [candidate] (29.087 ms) : 0, 29087
GlobalTracer [baseline] (258.449 ms) : 0, 258449
GlobalTracer [candidate] (256.419 ms) : 0, 256419
AppSec [baseline] (31.911 ms) : 0, 31911
AppSec [candidate] (31.551 ms) : 0, 31551
Debugger [baseline] (59.246 ms) : 0, 59246
Debugger [candidate] (58.717 ms) : 0, 58717
Remote Config [baseline] (628.951 µs) : 0, 629
Remote Config [candidate] (616.645 µs) : 0, 617
Telemetry [baseline] (8.758 ms) : 0, 8758
Telemetry [candidate] (8.662 ms) : 0, 8662
Flare Poller [baseline] (7.984 ms) : 0, 7984
Flare Poller [candidate] (8.615 ms) : 0, 8615
section iast
crashtracking [baseline] (1.208 ms) : 0, 1208
crashtracking [candidate] (1.192 ms) : 0, 1192
BytebuddyAgent [baseline] (795.05 ms) : 0, 795050
BytebuddyAgent [candidate] (796.498 ms) : 0, 796498
AgentMeter [baseline] (11.312 ms) : 0, 11312
AgentMeter [candidate] (11.406 ms) : 0, 11406
GlobalTracer [baseline] (247.082 ms) : 0, 247082
GlobalTracer [candidate] (248.786 ms) : 0, 248786
IAST [baseline] (25.1 ms) : 0, 25100
IAST [candidate] (25.306 ms) : 0, 25306
AppSec [baseline] (26.391 ms) : 0, 26391
AppSec [candidate] (26.561 ms) : 0, 26561
Debugger [baseline] (62.425 ms) : 0, 62425
Debugger [candidate] (63.014 ms) : 0, 63014
Remote Config [baseline] (518.847 µs) : 0, 519
Remote Config [candidate] (510.184 µs) : 0, 510
Telemetry [baseline] (14.84 ms) : 0, 14840
Telemetry [candidate] (14.844 ms) : 0, 14844
Flare Poller [baseline] (4.886 ms) : 0, 4886
Flare Poller [candidate] (4.871 ms) : 0, 4871
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 20 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f3f3ae9206, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (18.379 ms) : 18190, 18569
. : milestone, 18379,
appsec (18.687 ms) : 18499, 18875
. : milestone, 18687,
code_origins (17.747 ms) : 17569, 17925
. : milestone, 17747,
iast (18.083 ms) : 17904, 18262
. : milestone, 18083,
profiling (19.199 ms) : 19009, 19389
. : milestone, 19199,
tracing (17.66 ms) : 17485, 17834
. : milestone, 17660,
section candidate
no_agent (18.402 ms) : 18216, 18588
. : milestone, 18402,
appsec (19.074 ms) : 18880, 19268
. : milestone, 19074,
code_origins (17.837 ms) : 17660, 18015
. : milestone, 17837,
iast (18.541 ms) : 18354, 18729
. : milestone, 18541,
profiling (18.769 ms) : 18582, 18956
. : milestone, 18769,
tracing (18.073 ms) : 17894, 18251
. : milestone, 18073,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~f3f3ae9206, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (1.18 ms) : 1168, 1192
. : milestone, 1180,
iast (3.215 ms) : 3171, 3258
. : milestone, 3215,
iast_FULL (5.849 ms) : 5791, 5908
. : milestone, 5849,
iast_GLOBAL (3.625 ms) : 3566, 3685
. : milestone, 3625,
profiling (2.012 ms) : 1995, 2029
. : milestone, 2012,
tracing (1.766 ms) : 1752, 1780
. : milestone, 1766,
section candidate
no_agent (1.16 ms) : 1149, 1171
. : milestone, 1160,
iast (3.297 ms) : 3250, 3344
. : milestone, 3297,
iast_FULL (5.866 ms) : 5808, 5924
. : milestone, 5866,
iast_GLOBAL (3.616 ms) : 3557, 3675
. : milestone, 3616,
profiling (2.188 ms) : 2168, 2208
. : milestone, 2188,
tracing (1.87 ms) : 1851, 1890
. : milestone, 1870,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f3f3ae9206, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (3.811 ms) : 3589, 4033
. : milestone, 3811,
iast (2.265 ms) : 2196, 2335
. : milestone, 2265,
iast_GLOBAL (2.322 ms) : 2250, 2393
. : milestone, 2322,
profiling (2.101 ms) : 2046, 2157
. : milestone, 2101,
tracing (2.071 ms) : 2017, 2125
. : milestone, 2071,
section candidate
no_agent (1.479 ms) : 1468, 1491
. : milestone, 1479,
appsec (3.792 ms) : 3572, 4012
. : milestone, 3792,
iast (2.267 ms) : 2197, 2337
. : milestone, 2267,
iast_GLOBAL (2.311 ms) : 2241, 2382
. : milestone, 2311,
profiling (2.108 ms) : 2051, 2165
. : milestone, 2108,
tracing (2.065 ms) : 2012, 2119
. : milestone, 2065,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~f3f3ae9206, baseline=1.61.0-SNAPSHOT~8185dcf699
dateFormat X
axisFormat %s
section baseline
no_agent (15.031 s) : 15031000, 15031000
. : milestone, 15031000,
appsec (15.01 s) : 15010000, 15010000
. : milestone, 15010000,
iast (17.822 s) : 17822000, 17822000
. : milestone, 17822000,
iast_GLOBAL (18.105 s) : 18105000, 18105000
. : milestone, 18105000,
profiling (15.58 s) : 15580000, 15580000
. : milestone, 15580000,
tracing (15.121 s) : 15121000, 15121000
. : milestone, 15121000,
section candidate
no_agent (15.0 s) : 15000000, 15000000
. : milestone, 15000000,
appsec (15.13 s) : 15130000, 15130000
. : milestone, 15130000,
iast (18.268 s) : 18268000, 18268000
. : milestone, 18268000,
iast_GLOBAL (17.658 s) : 17658000, 17658000
. : milestone, 17658000,
profiling (14.818 s) : 14818000, 14818000
. : milestone, 14818000,
tracing (15.136 s) : 15136000, 15136000
. : milestone, 15136000,
|
PerfectSlayer
left a comment
There was a problem hiding this comment.
Thanks for the fix! Adding an additional suggestion for type check.
communication/src/main/java/datadog/communication/ddagent/DDAgentFeaturesDiscovery.java
Outdated
Show resolved
Hide resolved
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
930b2a6
into
master
What Does This Do
Fixes that recurring issue:
catching or skipping will at the end cause a fallback to be used. So functionally won't change but will avoid to fail with a NPE
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.