[web] Fix timing issue in run filter#4850
Open
gulyasgergely902 wants to merge 1 commit into
Open
Conversation
Run filter was getting the run name and tag from the global store which made it lose sync and not getting a valid result before setting the URL. This change returns the run id and tag to the update URL function without the need for global store to return the data in time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run filter was getting the run name and tag from the global store which made it lose sync and not getting a valid result before setting the URL. This change returns the run id and tag to the update URL function without the need for global store to return the data in time.