Skip to content

[WIP] fix: bounds isDefined doesn't vmap properly#244

Draft
beckermr wants to merge 2 commits into
mainfrom
fix-bounds-isdef-vmap
Draft

[WIP] fix: bounds isDefined doesn't vmap properly#244
beckermr wants to merge 2 commits into
mainfrom
fix-bounds-isdef-vmap

Conversation

@beckermr
Copy link
Copy Markdown
Collaborator

This attribute doesn't vmap and is used in a bunch of python control flow. Let's fix that.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will improve performance by 48.05%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 3 improved benchmarks
✅ 33 untouched benchmarks

Performance Changes

Mode Benchmark BASE HEAD Efficiency
WallTime test_benchmarks_lanczos_interp[xval-conserve_dc-run] 138.9 µs 98.4 µs +41.06%
WallTime test_benchmarks_lanczos_interp[kval-no_conserve_dc-run] 59.4 µs 44.4 µs +33.75%
WallTime test_benchmark_moffat_init[run] 100.6 µs 58.5 µs +72%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix-bounds-isdef-vmap (9f3297d) with main (948d92b)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant