[libcu++] Make resource an environment when queried for a resource #7113
+60
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 6708395 |
This comment has been minimized.
This comment has been minimized.
miscco
reviewed
Jan 8, 2026
| //! @brief `__get_memory_resource_t` is a customization point object that queries a type `T` for an associated memory | ||
| //! @brief `get_memory_resource_t` is a customization point object that queries a type `T` for an associated memory | ||
| //! resource | ||
| struct __get_memory_resource_t |
Contributor
There was a problem hiding this comment.
My memory is fuzzy here, why did we keep this internal last release?
Contributor
Author
There was a problem hiding this comment.
I am not sure, but I think we can just remove the internal name usage
Contributor
😬 CI Workflow Results🟥 Finished in 5h 43m: Pass: 97%/136 | Total: 5d 14h | Max: 5h 43m | Hits: 88%/272253See results here. |
Contributor
Author
|
Closing in favor of #7266 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced environment based APIs in CUB, but right now you need to use:
It would be better to just do
like we do with a stream. This PR adds an overload accepting a resource to
cuda::mr::get_memory_resource, like we do withget_stream. It would be a burden to require every resource to declarecuda::mr::get_memory_resourcequery, so instead this PR changescuda::std::execution::__query_orto also try to call the supplied query with the env as an argument, to utilize the newly added overload incuda::mr::get_memory_resource