FIX: Adding [NonSerialized] to layouts (struct RemoteSender)#2396
Open
josepmariapujol-unity wants to merge 2 commits intodevelopfrom
Open
FIX: Adding [NonSerialized] to layouts (struct RemoteSender)#2396josepmariapujol-unity wants to merge 2 commits intodevelopfrom
josepmariapujol-unity wants to merge 2 commits intodevelopfrom
Conversation
josepmariapujol-unity
changed the title
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Packages/com.unity.inputsystem/InputSystem/Devices/Remote/InputRemoting.cs
Show resolved
Hide resolved
K-Tone
approved these changes
Mar 24, 2026
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2396 +/- ##
=========================================
Coverage 77.90% 77.91%
=========================================
Files 476 482 +6
Lines 97613 97756 +143
=========================================
+ Hits 76048 76163 +115
- Misses 21565 21593 +28 Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added
[NonSerialized]to the layouts field at InputRemoting.cs:383. This suppresses the UAC1001 warning without touching InternedString or affecting runtime behavior, the field is purely transient state tracking which layouts were received from a remote sender.Fixed 6000.6 editor warning:
Packages/com.unity.inputsystem/InputSystem/Devices/Remote/InputRemoting.cs(383,37): warning UAC1001: Field 'layouts' is a candidate for serialization but Unity will skip it because its type 'UnityEngine.InputSystem.Utilities.InternedString' lacks [Serializable] attribute. To fix this, either: make the field private (if serialization is not desired), add [System.NonSerialized] (to explicitly mark it as non-serialized), or add [Serializable] to type 'UnityEngine.InputSystem.Utilities.InternedString' (if serialization is desired).Previous PR: #2381
Testing status & QA
No need to do manual testing.
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.