chore: [Optimize accessors] NetworkTransform#3907
Merged
noellie-velez merged 12 commits intodevelop-2.0.0from Apr 2, 2026
Merged
chore: [Optimize accessors] NetworkTransform#3907noellie-velez merged 12 commits intodevelop-2.0.0from
noellie-velez merged 12 commits intodevelop-2.0.0from
Conversation
noellie-velez
commented
Mar 18, 2026
com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Mar 18, 2026
com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
Outdated
Show resolved
Hide resolved
noellie-velez
commented
Mar 18, 2026
com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
Outdated
Show resolved
Hide resolved
noellie-velez
changed the title
noellie-velez
commented
Mar 19, 2026
com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
Outdated
Show resolved
Hide resolved
noellie-velez
changed the title
EmandM
reviewed
Mar 30, 2026
com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
Outdated
Show resolved
Hide resolved
…ansform # Conflicts: # com.unity.netcode.gameobjects/CHANGELOG.md
EmandM
approved these changes
Apr 1, 2026
NoelStephensUnity
approved these changes
Apr 1, 2026
Member
NoelStephensUnity
left a comment
NoelStephensUnity
left a comment
There was a problem hiding this comment.
Provided a suggested change to assignment of the cached tick rate and NetworkObject to group the more "constant" cached value assignments into the same location.
Other than that minor adjustment... it looks good to me! 👍
com.unity.netcode.gameobjects/Runtime/Components/NetworkTransform.cs
Outdated
Show resolved
Hide resolved
| /// </summary> | ||
| /// <param name="networkTransform"></param> | ||
| private static void RegisterForTickUpdate(NetworkTransform networkTransform) | ||
| private void RegisterForTickUpdate() |
Member
There was a problem hiding this comment.
Good catch and adjustment!
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Jira ticket
closes: #3743
MTT-14675
Changelog
NetworkTransform.Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
N/A