[UUM-133530] Ensure "Set Double Sided" is enabled when active selection is proper#660
Open
[UUM-133530] Ensure "Set Double Sided" is enabled when active selection is proper#660
Conversation
…e enabled in the contextual menu due to a missing override.
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
| @@ -38,9 +38,11 @@ public class MakeFacesDoubleSided : MenuAction | |||
| /// <returns></returns> | |||
There was a problem hiding this comment.
The XML documentation tag is empty and is generally used for methods rather than properties. For properties, the
or tags are standard. Consider removing the empty tag to keep the documentation clean.
🤖 Helpful? 👍/👎
varinotmUnity
approved these changes
Mar 13, 2026
Contributor
varinotmUnity
left a comment
varinotmUnity
left a comment
There was a problem hiding this comment.
nice, users have been asking for this for a while on forums :)
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## master #660 +/- ##
=======================================
Coverage 36.05% 36.06%
=======================================
Files 277 277
Lines 34909 34910 +1
=======================================
+ Hits 12588 12589 +1
Misses 22321 22321
Flags with carried forward coverage won't be shown. Click here to find out more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT FORGET TO INCLUDE A CHANGELOG ENTRY
Purpose of this PR
Implementation of the menu action was missing two elements:
base.enabledthat does some extra checks to validate that the selection context is correct with the providedvalidSelectModes. It's a common pattern in ProBuilder (look at all PB's menu action).hasFileMenuEntryneeds to be set to false. Base implementation returnstruebut that would indicate that the custom action exists somewhere in the top menu as the code would try to resolve the action by looking up at the one from the top menu.Links
Jira: UUM-133530