Add note to TriggerDagRunOperator #60407
Conversation
arnoldmr01
requested review from
amoghrajesh,
ashb,
ephraimbuddy,
jason810496,
kaxil,
pierrejeambrun and
rawwar
as code owners
boring-cyborg
bot
added
area:API
| state=DagRunState.QUEUED, | ||
| session=session, | ||
| ) | ||
|
|
There was a problem hiding this comment.
I think it should be
| if note: | |
| dag_run.note = note |
arnoldmr01
force-pushed
the
feature/trigger-dagrun-support-note
branch
from
18bb27d to
44bd79a
Compare
arnoldmr01
force-pushed
the
feature/trigger-dagrun-support-note
branch
from
44bd79a to
791fa6a
Compare
There was a problem hiding this comment.
Did you test this? And verified that the triggered dagrun had the appropriate note?
After the exception is raised with the additional note field, we need to update the sdk code to have that handled. (mostly, supervisor.py).
That PR seems completely off (not tested, not double checked, not complying with our "contributing with AI" guidelines, closing feel free to re-open if I misunderstood something.
| if self.note: | ||
| dag_run = session.merge(dag_run) | ||
| dag_run.note = self.note | ||
| session.flush() |
There was a problem hiding this comment.
Why is that on the _trigger_dag_af_2 ? TriggerDagRunOperator note will not be handled anyway, do we need that?
There was a problem hiding this comment.
So far, note information can be passed via UI and API, but TriggerDagRunOperator doesn't allow to pass note information. I put this part here in order to store the note information.
| # [START howto_operator_trigger_dagrun_with_note] | ||
| trigger_with_note = TriggerDagRunOperator( | ||
| task_id="trigger_with_note", | ||
| trigger_dag_id="example_trigger_target_dag", | ||
| note="Triggered with a note!", | ||
| ) | ||
| # [END howto_operator_trigger_dagrun_with_note] |
There was a problem hiding this comment.
This example section probably need to be added to the corresponding doc file
3 participants
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.