Skip to content

fix : prevent bun response headers from leaking into transaction telemetry #19811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
naaa760 wants to merge 1 commit into from
Closed

fix : prevent bun response headers from leaking into transaction telemetry #19811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/bun/src/integrations/bunserver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,6 @@ function wrapRequestHandler<T extends RouteHandler = RouteHandler>(
if (response?.status) {
setHttpStatus(span, response.status);
isolationScope.setContext('response', {
headers: response.headers.toJSON(),
Copy link

@cursor cursor bot Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing regression test for the header leak fix

Low Severity

This fix PR removes response headers from the isolation scope context but does not include a regression test verifying that the response context set via isolationScope.setContext contains only status_code and no headers. A test asserting the absence of headers in the response context would prevent this leak from being reintroduced. The review rules require fix PRs to include at least one test that covers the regression being fixed.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

status_code: response.status,
});
}
Expand Down
Loading