feat(deno): Set http response header attributes instead of response context headers#19822
Merged
feat(deno): Set http response header attributes instead of response context headers#19822
Conversation
Lms24
changed the base branch from
develop
to
lms/feat-bun-http-response-headers
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
force-pushed
the
lms/feat-deno-http-response-headers
branch
from
55ae96e to
73b8f35
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Inconsistent sendDefaultPii handling misses nullish coalescing
- Replaced client.getOptions().sendDefaultPii with the already-resolved sendDefaultPii local variable for consistency and proper nullish coalescing.
Or push these changes by commenting:
@cursor push b0be4199ba
Preview (b0be4199ba)
diff --git a/packages/deno/src/wrap-deno-request-handler.ts b/packages/deno/src/wrap-deno-request-handler.ts
--- a/packages/deno/src/wrap-deno-request-handler.ts
+++ b/packages/deno/src/wrap-deno-request-handler.ts
@@ -98,11 +98,7 @@
status_code: res.status,
});
span.setAttributes(
- httpHeadersToSpanAttributes(
- Object.fromEntries(res.headers),
- client.getOptions().sendDefaultPii,
- 'response',
- ),
+ httpHeadersToSpanAttributes(Object.fromEntries(res.headers), sendDefaultPii, 'response'),
);
} catch (e) {
span.end();This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.
s1gr1d
approved these changes
Mar 17, 2026
Lms24
commented
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
same as #19821 but for deno server instrumentation. To be merged after #19821
ref #19790