Skip to content

feat(deno): Set http response header attributes instead of response context headers #19822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 7 commits into from
Mar 17, 2026
Merged

feat(deno): Set http response header attributes instead of response context headers #19822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
bd77d5a
feat(bun): Set http response header attributes instead of response co…
Lms24 Mar 16, 2026
9189e28
bun test, unit tests
Lms24 Mar 16, 2026
73b8f35
feat(deno): Set http response header attributes instead of response c…
Lms24 Mar 16, 2026
a1144ba
adjust denot test
Lms24 Mar 16, 2026
e6111a0
cleanup sendDefaultPii retrieval in deno
Lms24 Mar 16, 2026
b6a1845
Merge branch 'develop' into lms/feat-deno-http-response-headers
Lms24 Mar 17, 2026
a22f893
Apply suggestion from @Lms24
Lms24 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/deno/src/wrap-deno-request-handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,7 @@ export const wrapDenoRequestHandler = <Addr extends Deno.Addr = Deno.Addr>(
assignIfSet(attributes, 'client.port', (info?.remoteAddr as Deno.NetAddr)?.port);
}

Object.assign(
attributes,
httpHeadersToSpanAttributes(winterCGHeadersToDict(request.headers), client.getOptions().sendDefaultPii ?? false),
);
Object.assign(attributes, httpHeadersToSpanAttributes(winterCGHeadersToDict(request.headers), sendDefaultPii));
attributes[SEMANTIC_ATTRIBUTE_SENTRY_OP] = 'http.server';
isolationScope.setSDKProcessingMetadata({
normalizedRequest: winterCGRequestToRequestData(request),
Expand All @@ -95,9 +92,11 @@ export const wrapDenoRequestHandler = <Addr extends Deno.Addr = Deno.Addr>(
res = await handler();
setHttpStatus(span, res.status);
isolationScope.setContext('response', {
headers: Object.fromEntries(res.headers),
status_code: res.status,
});
span.setAttributes(
httpHeadersToSpanAttributes(Object.fromEntries(res.headers), sendDefaultPii, 'response'),
);
} catch (e) {
span.end();
captureException(e, {
Expand Down
5 changes: 2 additions & 3 deletions packages/deno/test/deno-serve.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,8 @@ Deno.test('Deno.serve should capture request headers and set response context',

// Check response context
assertEquals(transaction?.contexts?.response?.status_code, 201);
assertExists(transaction?.contexts?.response?.headers);
assertEquals(transaction?.contexts?.response?.headers?.['content-type'], 'text/plain');
assertEquals(transaction?.contexts?.response?.headers?.['x-custom-header'], 'test');
assertEquals(transaction?.contexts?.trace?.data?.['http.response.header.content_type'], 'text/plain');
assertEquals(transaction?.contexts?.trace?.data?.['http.response.header.x_custom_header'], 'test');
});

Deno.test('Deno.serve should support distributed tracing with sentry-trace header', async () => {
Expand Down
Loading