fix: TypeScript package regressions, remove files property from package.json #8832
+662
−194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
russellwheatley
changed the title
in the packages recently converted to typescript a files array was added to package.json, but it was too restrictive and did not include all the files library consumers needed a correct files array could be a benefit and may be explored in the future but for now including all the files previously included (that is, everything not in .npmignore) should satisfy needs of library consumers with the slight risk of including a bit too much and increasing bundle size
mikehardy
force-pushed
the
fix-package-json-regression
branch
from
3820f14 to
144bc8a
Compare
mikehardy
force-pushed
the
fix-package-json-regression
branch
from
144bc8a to
545007b
Compare
…e ai otherwise the ai module attempts to transpile from typescript to javascript prior to the dependency typescript definitions exist, which fails the transpile
mikehardy
force-pushed
the
fix-package-json-regression
branch
from
545007b to
fe0cfe2
Compare
investigating a transpiler failure in app-check and best to use current stable version vs old versions
…ation if the JS is present alongside the TS, the typescript compiler engages in a race with itself inside the same file, and the final contents are indeterminant - may be the original JS, may be the pure TS transpile, or could be a mix of the two that won't compile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
filesarray was added topackage.jsonwhich was too exclusiveA
filesarray that is correct is a good thing as it ensures the installed packages and resulting app bundle are optimal - including nothing unnecessary, so this will likely be redone in the futureHowever a
filesarray that is missing critical files is an error and this rendered the resulting published packages useless for library consumers as they were missing the native files and the Expo plugins.Additionally, a cross-package dependency from ai to app-check was not expressed correctly and after typescript conversion this meant app-check typescript wasn't transpiled before ai package needed it sometimes.
Finally, the "other" e2e run was failing to parse app-check but only sometimes. Root cause was traced to indeterminant transpile output from
tscbecause the pre-typescript-migration javascript files were still present, and the final transpiled js files got a mix of original, transpile, or partial-of-each in their final content. Removed the original JS filesRelated issues
Release Summary
Fix release, conventional commits
Checklist
AndroidiOSOther(macOS, web)e2etests added or updated inpackages/\*\*/e2ejesttests added or updated inpackages/\*\*/__tests__Test Plan
revert of files change should be sufficient, however
Think
react-native-firebaseis great? Please consider supporting the project with any of the below:React Native FirebaseandInvertaseon Twitter