Skip to content

update to Go 1.26.2#153

Open
xrstf wants to merge 3 commits intokcp-dev:mainfrom
xrstf:go126
Open

update to Go 1.26.2#153
xrstf wants to merge 3 commits intokcp-dev:mainfrom
xrstf:go126

Conversation

@xrstf
Copy link
Copy Markdown
Contributor

@xrstf xrstf commented Apr 8, 2026 •
edited
Loading

Summary

This bumps us to the latest Go version, including many security fixes.

I also included the updated PR template from the kcp operator, giving friendly hints at AI agents to focus less on repetitive noise.

What Type of PR Is This?

/kind chore

Release Notes

Update to Go 1.26.2.

xrstf added 2 commits April 8, 2026 16:11
@xrstf
update to Go 1.26.2
19a7492 
On-behalf-of: @SAP christoph.mewes@sap.com
@xrstf
modernize PR template, include chore label
792a4b2 
On-behalf-of: @SAP christoph.mewes@sap.com
@kcp-ci-bot kcp-ci-bot added kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Apr 8, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Apr 8, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign embik for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 8, 2026
@xrstf
Copy link
Copy Markdown
Contributor Author

xrstf commented Apr 8, 2026

/retest

@xrstf xrstf requested a review from gman0 April 10, 2026 10:59
gman0
gman0 reviewed Apr 10, 2026
View reviewed changes
go.mod
module github.com/kcp-dev/api-syncagent

go 1.25.7
go 1.25.0
Copy link
Copy Markdown
Contributor

@gman0 gman0 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: #137 (comment)

Copy link
Copy Markdown
Contributor

@gman0 gman0 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not change the minor version at least?

Copy link
Copy Markdown
Contributor Author

@xrstf xrstf Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we? The SDK compiles fine with Go 1.25 and if someone is still on 1.25, we shouldn't force them to upgrade to Go for no reason. The go directive is the compiler-compatibilty level, not a build recommendation 😁

gman0
gman0 reviewed Apr 10, 2026
View reviewed changes
@xrstf
fix typos
799e6c7 
On-behalf-of: @SAP christoph.mewes@sap.com
@gman0
Copy link
Copy Markdown
Contributor

gman0 commented Apr 10, 2026

Feel free to also update the PR desc with the context for your other commit in this PR :P

/lgtm

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

kcp-ci-bot commented Apr 10, 2026

LGTM label has been added.

DetailsGit tree hash: 61b74e8d1c76fb10558e443733473c6e003d7d35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gman0 gman0 gman0 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@gman0 gman0

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/chore Categorizes issue or PR as related to maintenance and other usually non-code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xrstf @kcp-ci-bot @gman0