Skip to content

update to Go 1.26.2 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xrstf wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update to Go 1.26.2 #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
19a7492
update to Go 1.26.2
xrstf Apr 8, 2026
792a4b2
modernize PR template, include chore label
xrstf Apr 8, 2026
799e6c7
fix typos
xrstf Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,26 @@
<!--

Thanks for creating a pull request!
If this is your first time, please make sure to review CONTRIBUTING.MD.
If this is your first time, please make sure to review CONTRIBUTING.md.

-->

## Summary
<!--
Please provide a description that explains *why* your PR is changing something
in the codebase, and focus less on *what* you're changing. The following are
good questions to ask yourself when writing the PR summary:

## What Type of PR Is This?
* What are the problems you are trying to solve?
* What assumptions did you make when implementing your changes?
* Which workflows will be affected/improved by your change?
-->

## What Type of PR Is This?
<!--

Add one of the following kinds:
/kind bug
/kind chore
/kind cleanup
/kind documentation
/kind feature
Expand All @@ -23,19 +31,16 @@ Optionally add one or more of the following kinds if applicable:
/kind failing-test
/kind flake
/kind regression

-->

## Related Issue(s)

Fixes #

## Release Notes

<!--
Please add a release note in the block below. Leave NONE only if no user-facing changes are in this PR.
Please add a release note in the block below.
Leave NONE only if no user-facing changes are in this PR.
-->

```release-note
NONE
```
2 changes: 1 addition & 1 deletion .github/workflows/docs-gen-and-push.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # tag=v6.1.0
with:
go-version: v1.25.7
go-version: v1.26.2
cache: true

- uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 #tag=v6.1.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@4dc6199c7b1a012772edbd06daecab0f50c9053c # tag=v6.1.0
with:
go-version: v1.24.11
go-version: v1.26.2
cache: true

- name: Delete non-semver tags
Expand Down
12 changes: 6 additions & 6 deletions .prow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.25.7-1
- image: ghcr.io/kcp-dev/infra/build:1.26.2-1
command:
- hack/ci/verify.sh
resources:
Expand All @@ -37,7 +37,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.25.7-1
- image: ghcr.io/kcp-dev/infra/build:1.26.2-1
command:
- make
- lint
Expand Down Expand Up @@ -76,7 +76,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.25.7-1
- image: ghcr.io/kcp-dev/infra/build:1.26.2-1
command:
- make
- test
Expand All @@ -96,7 +96,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.25.7-1
- image: ghcr.io/kcp-dev/infra/build:1.26.2-1
command:
- hack/ci/run-e2e-tests.sh
env:
Expand All @@ -115,7 +115,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.25.7-1
- image: ghcr.io/kcp-dev/infra/build:1.26.2-1
command:
- hack/ci/run-e2e-tests.sh
env:
Expand All @@ -134,7 +134,7 @@ presubmits:
preset-goproxy: "true"
spec:
containers:
- image: ghcr.io/kcp-dev/infra/build:1.25.7-1
- image: ghcr.io/kcp-dev/infra/build:1.26.2-1
command:
- hack/ci/run-e2e-tests.sh
env:
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

FROM --platform=${BUILDPLATFORM} docker.io/golang:1.25.7 AS builder
FROM --platform=${BUILDPLATFORM} docker.io/golang:1.26.2 AS builder
ARG TARGETOS
ARG TARGETARCH

Expand Down
2 changes: 1 addition & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/kcp-dev/api-syncagent

go 1.25.7
go 1.25.0
Copy link
Copy Markdown
Contributor

@gman0 gman0 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the record: #137 (comment)

Copy link
Copy Markdown
Contributor

@gman0 gman0 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not change the minor version at least?

Copy link
Copy Markdown
Contributor Author

@xrstf xrstf Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would we? The SDK compiles fine with Go 1.25 and if someone is still on 1.25, we shouldn't force them to upgrade to Go for no reason. The go directive is the compiler-compatibilty level, not a build recommendation 😁


replace github.com/kcp-dev/api-syncagent/sdk => ./sdk

Expand Down
Loading