fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure#17560
Open
WithEnoughCoffee wants to merge 1 commit into
Open
fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure#17560WithEnoughCoffee wants to merge 1 commit into
WithEnoughCoffee wants to merge 1 commit into
Conversation
The tests bcond (enabled by default when %rhel is undefined) causes %pyproject_buildrequires -g test to generate dynamic BuildRequires for test dependencies (filelock, pytest-mock, setuptools_scm, etc.) that may not be published in the Koji build tag at build time, resulting in mock exit status 30 (BR-unresolvable). Disable tests and extras via build.without, aligning with RHEL behavior as the spec was designed for. The %pyproject_check_import basic sanity check still runs. Fixes: Koji task 2593995 Related: AB#20330
WithEnoughCoffee
force-pushed
the
fix/python-build-br-unresolvable
branch
from
c438370 to
efa7560
Compare
WithEnoughCoffee
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Disables extras and tests build conditionals for the python-build component to avoid dynamically generated test/extra BuildRequires that can be missing from the Koji nightly tag, while retaining a basic %pyproject_check_import sanity check.
Changes:
- Add
build.without = ["extras", "tests"]forpython-buildvia a dedicated component definition file. - Re-render
python-buildspec output to include the generated.azl.macrosfile and updated rpmautospec release/changelog. - Update the
python-buildlock input fingerprint to match the new component configuration, and removepython-buildfrom the “unmodified inline” component list.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
base/comps/python-build/python-build.comp.toml |
Adds component build configuration to disable extras/tests bconds with rationale. |
base/comps/components.toml |
Removes python-build from the inline “unmodified” component list since it’s now customized. |
locks/python-build.lock |
Updates input-fingerprint to reflect the new component config inputs. |
specs/p/python-build/python-build.spec |
Rendered spec updated to load generated macros, add Source9999, and bump release/changelog. |
specs/p/python-build/python-build.azl.macros |
Generated macros file defining %_without_extras and %_without_tests. |
reubeno
requested changes
May 30, 2026
| @@ -0,0 +1,11 @@ | |||
| # AZL does not ship python3-uv or python3-build+uv/+virtualenv extras subpackages. | |||
Member
There was a problem hiding this comment.
uv is present in AZL4, and it provides python3-uv. I think the real issue is that uv isn't building correctly.
Unless we're proposing removal of uv, let's try to address that root cause.
| # via %pyproject_buildrequires -x virtualenv,uv, causing BR-unresolvable failures. | ||
| # | ||
| # Tests are disabled to align with RHEL — the spec notes "not all test dependencies | ||
| # are included in RHEL: filelock, pytest-mock". The dynamic test BRs (via -g test) |
Member
There was a problem hiding this comment.
Does AZL4 provide filelock, pytest-mock*, though? That's relevant.
| # | ||
| # Tests are disabled to align with RHEL — the spec notes "not all test dependencies | ||
| # are included in RHEL: filelock, pytest-mock". The dynamic test BRs (via -g test) | ||
| # create fragile ordering dependencies in the Koji nightly build tag, causing |
Member
There was a problem hiding this comment.
What's meant by "fragile ordering dependencies"?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disables the
testsandextrasbconds for python-build to fix BR-unresolvable failures in the Koji nightly build (task 2593995).Root Cause
The
testsbcond (enabled by default when%rhelis undefined) causes%pyproject_buildrequires -g testto generate dynamic BuildRequires for test dependencies (filelock, pytest-mock, setuptools_scm, etc.) that may not be published in the Koji build tag at build time, resulting in mock exit status 30.Fix
Add
build.without = ["extras", "tests"]— aligning with RHEL behavior as the spec was designed for. The%pyproject_check_importbasic sanity check still runs.Testing
pyproject-build --version→build 1.3.0✓build,ProjectBuilder,DefaultIsolatedEnv) all work ✓References