Skip to content

fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure #17560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WithEnoughCoffee wants to merge 1 commit into
base: 4.0
Choose a base branch
from
Open

fix(python-build): disable tests bcond to fix BR-unresolvable nightly failure #17560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion base/comps/components.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3546,7 +3546,6 @@ includes = ["**/*.comp.toml", "component-check-disablement.toml", "component-min
[components.python-botocore]
[components.python-breathe]
[components.python-bsddb3]
[components.python-build]
[components.python-cached_property]
[components.python-cachetools]
[components.python-cairocffi]
Expand Down
11 changes: 11 additions & 0 deletions base/comps/python-build/python-build.comp.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# AZL does not ship python3-uv or python3-build+uv/+virtualenv extras subpackages.
Copy link
Copy Markdown
Member

@reubeno reubeno May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uv is present in AZL4, and it provides python3-uv. I think the real issue is that uv isn't building correctly.

Unless we're proposing removal of uv, let's try to address that root cause.

# The extras bcond (default ON via %{undefined rhel}) pulls uv into BuildRequires
# via %pyproject_buildrequires -x virtualenv,uv, causing BR-unresolvable failures.
#
# Tests are disabled to align with RHEL — the spec notes "not all test dependencies
# are included in RHEL: filelock, pytest-mock". The dynamic test BRs (via -g test)
Copy link
Copy Markdown
Member

@reubeno reubeno May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does AZL4 provide filelock, pytest-mock*, though? That's relevant.

# create fragile ordering dependencies in the Koji nightly build tag, causing
Copy link
Copy Markdown
Member

@reubeno reubeno May 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's meant by "fragile ordering dependencies"?

# BR-unresolvable failures (task 2593995).
# %pyproject_check_import still runs as a basic sanity check.
[components.python-build]
build.without = ["extras", "tests"]
2 changes: 1 addition & 1 deletion locks/python-build.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
version = 1
import-commit = '30b4e152e5d7c953489ac1ede1453523e1831387'
upstream-commit = '30b4e152e5d7c953489ac1ede1453523e1831387'
input-fingerprint = 'sha256:ae84fee305eb05777ea00ff61f6f7c38f21311a598bebdffd49c6c0d7a5a7fb4'
input-fingerprint = 'sha256:2c924a7df146d698b268c844cfc23c2743f859ccade45b5b0e964aa781aa31d7'
resolution-input-hash = 'sha256:466421704711c4fd3c71f0b2ed715a0e61d49e3e26f3a2637fee755795849c8e'
4 changes: 4 additions & 0 deletions specs/p/python-build/python-build.azl.macros
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Macros file automatically generated by azldev.
# Do not edit manually; changes will be overwritten.
%_without_extras 1
%_without_tests 1
9 changes: 8 additions & 1 deletion specs/p/python-build/python-build.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
## (rpmautospec version 0.8.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
release_number = 5;
release_number = 6;
base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
print(release_number + base_release_number - 1);
}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
Expand All @@ -11,6 +11,9 @@
# This spec file has been modified by azldev to include build configuration overlays.
# Do not edit manually; changes may be overwritten.

# All Azure Linux specs with overlays include this macro file, irrespective of whether new macros have been added.
%{load:%{_sourcedir}/python-build.azl.macros}

# not all test dependencies are included in RHEL: filelock, pytest-mock
%bcond tests %{undefined rhel}
# uv has many build dependencies which are not included in RHEL;
Expand All @@ -27,6 +30,7 @@ Summary: A simple, correct PEP517 package builder
License: MIT
URL: https://github.com/pypa/build
Source0: %{url}/archive/%{version}/%{pypi_name}-%{version}.tar.gz
Source9999: python-build.azl.macros

# downstream-only
Patch: 0001-fedora-disable-some-build-requirements.patch
Expand Down Expand Up @@ -92,6 +96,9 @@ A simple, correct PEP517 package builder.

%changelog
## START: Generated by rpmautospec
* Fri May 29 2026 Autumn Nash <autumnnash@microsoft.com> - 1.3.0-6
- python-build: disable tests bcond to fix BR-unresolvable nightly failure

* Thu Apr 30 2026 Daniel McIlvaney <damcilva@microsoft.com> - 1.3.0-5
- feat: introduce deterministic commit resolution via Azure Linux lock file

Expand Down
Loading