fix: widen elicitInput requestedSchema to accept Zod JSON Schema output#1686
Open
travisbreaks wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: widen elicitInput requestedSchema to accept Zod JSON Schema output#1686travisbreaks wants to merge 1 commit intomodelcontextprotocol:mainfrom
travisbreaks wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Zod's .toJSONSchema() output includes standard JSON Schema fields like $schema and additionalProperties that the current type rejects. This causes TypeScript errors even though the runtime handles them fine. - Add .passthrough() to the requestedSchema Zod schema so extra fields pass validation and are reflected in the inferred type - Add additionalProperties and index signature to the spec interface Fixes modelcontextprotocol#1362 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 6c3feb3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/server
@modelcontextprotocol/express
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.passthrough()toElicitRequestFormParamsSchemaso Zod validation accepts extra JSON Schema fieldsElicitRequestFormParamsspec type for TypeScript compatibilityz.object().toJSONSchema()now works without type castingFixes #1362
Context
Zod's
.toJSONSchema()produces valid JSON Schema with fields like$schemaandadditionalPropertiesthat the current type rejects at the TypeScript level, even though runtime behavior is correct. Rather than allowlisting individual fields,.passthrough()and an index signature handle any standard JSON Schema output generically.Test plan
.toJSONSchema()output matches widened type