fix(web): remove v prefix from version in page title#744
fix(web): remove v prefix from version in page title#744sujalgoel wants to merge 3 commits intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
- Coverage 77.17% 77.17% -0.01%
==========================================
Files 153 153
Lines 13771 13782 +11
Branches 1114 1115 +1
==========================================
+ Hits 10628 10636 +8
- Misses 3139 3142 +3
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It would be nice to see this fixed! I didn't attempt to submit any PR myself for this issue because I assumed that the new website format (see nodejs/node#52343) would be promoted to production much sooner. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Aligns with the Node.js documentation style guide which specifies version references should not include the v prefix. Closes nodejs#722
Moves the title suffix string into defaultConfiguration as a
template ("Node.js {version} Documentation") and uses populate()
to resolve it at runtime, consistent with how other config
strings are handled.
Fixes nodejs#722
sujalgoel
force-pushed
the
fix/version-header-v-prefix
branch
from
8c7af7a to
f27f242
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Thanks for the context. The fix still makes sense regardless of the UI format since it removes the hardcoded v prefix and moves the title string into defaultConfiguration where it can be overridden per project. Happy to defer to the maintainers on whether to merge. |
|
Yes, this should be merged (after our 48hr review time) |
5 participants
The page title currently renders as "Node.js v25.4.0 Documentation". The Node.js documentation style guide specifies that version references should not include the
vprefix.Removes the
vfrom the template string inprocessJSXEntriesso the title renders as "Node.js 25.4.0 Documentation".Fixes #722