Skip to content

fix(web): remove v prefix from version in page title #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sujalgoel wants to merge 3 commits into
base: main
Choose a base branch
from
+13 −2
Open

fix(web): remove v prefix from version in page title #744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
797c8d3
fix(web): remove v prefix from version in page title
sujalgoel Apr 1, 2026
ba690e0
fix(web): use populate() for title suffix template
sujalgoel Apr 2, 2026
f27f242
test(web): add test for titleSuffix template resolution
sujalgoel Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/generators/web/index.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export default createLazyGenerator({
defaultConfiguration: {
templatePath: join(import.meta.dirname, 'template.html'),
title: 'Node.js',
titleSuffix: 'Node.js {version} Documentation',
editURL: `${GITHUB_EDIT_URL}/doc/api{path}.md`,
pageURL: '{baseURL}/latest-{version}/api{path}.html',
imports: {
Expand Down
7 changes: 5 additions & 2 deletions src/generators/web/utils/processing.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { createChunkedRequire } from './chunks.mjs';
import createConfigSource from './config.mjs';
import createASTBuilder from './generate.mjs';
import getConfig from '../../../utils/configuration/index.mjs';
import { populate } from '../../../utils/configuration/templates.mjs';
import { minifyHTML } from '../../../utils/html-minifier.mjs';
import { relative } from '../../../utils/url.mjs';
import { SPECULATION_RULES } from '../constants.mjs';
Expand Down Expand Up @@ -79,7 +80,7 @@ async function executeServerCode(serverCodeMap, requireFn, virtualImports) {
* @param {string} template - The HTML template string for the output pages.
*/
export async function processJSXEntries(entries, template) {
const { version } = getConfig('web');
const { version, titleSuffix: titleSuffixTemplate } = getConfig('web');
const astBuilders = createASTBuilder();
const requireFn = createRequire(import.meta.url);
const virtualImports = {
Expand All @@ -98,7 +99,9 @@ export async function processJSXEntries(entries, template) {
bundleCode(clientCodeMap, virtualImports),
]);

const titleSuffix = `Node.js v${version.version} Documentation`;
const titleSuffix = populate(titleSuffixTemplate, {
version: version.version,
});

// Step 3: Render final HTML pages
const results = await Promise.all(
Expand Down
7 changes: 7 additions & 0 deletions src/utils/configuration/__tests__/templates.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,11 @@ describe('populate', () => {
const result = populate('{missing}', {});
assert.strictEqual(result, '{missing}');
});

it('should resolve the web generator titleSuffix template', () => {
const result = populate('Node.js {version} Documentation', {
version: '22.0.0',
});
assert.strictEqual(result, 'Node.js 22.0.0 Documentation');
});
});
Loading