feat: add route and menu support for axis domain-* by gururaj1512 · Pull Request #11858 · stdlib-js/stdlib

gururaj1512 · 2026-04-30T08:55:07Z

Resolves None

Description

What is the purpose of this pull request?

This pull request:

feat: add route and menu support for axis domain-*

Screen.Recording.2026-04-30.at.2.18.46.PM.mov

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Needs fix: properties not updating correctly without refresh #11857 to be merged

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

Yes
No

If you answered "yes" above, how did you use AI assistance?

Code generation (e.g., when writing an implementation or fixing a bug)
Test/benchmark generation
Documentation (including examples)
Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

@stdlib-js/reviewers

gururaj1512 · 2026-04-30T08:57:11Z

@kgryte, You may see here that domain when set to false is not reflecting the changes. Seems like a bug — I tried to identify the cause but couldn't find it. Needs to be resolved.

gururaj1512 · 2026-05-01T15:33:31Z

Since the domain property in Vega axes is defined as a static boolean, it behaves as an initialization-time configuration rather than a reactive one.

To address this limitation, a practical workaround is to dynamically set domainOpacity to 0 whenever domain is set to false. This approach ensures the UI behaves smoothly and aligns with expected visual outcomes.

Demo:

Screen.Recording.2026-05-01.at.9.03.36.PM.mov

kgryte · 2026-05-04T09:24:29Z

@gururaj1512 I believe you can go ahead and update this PR now that the domain bug has been addressed.

kgryte · 2026-05-04T09:26:21Z

You'll likely need to merge in the latest from the refactor/plot branch and regenerate the bundle.

gururaj1512 · 2026-05-04T09:47:36Z

domainDash needs to be yet updated to use comma separated values instead of [].

Changed the default domainOpacity value from 0 to 1. Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

kgryte · 2026-05-04T21:56:59Z

+			'default': [],
+			'type': 'array',
+			'items': {
+				'type': 'number'
+			},
+			'minItems': 0


Is this a valid lil gui configuration?

Maybe stated differently, is this the first instance of us adding a configuration like this?

Did a look through the code; I believe this is a first. I am guessing you are basing this off of JSON schema?

I am curious what is the larger context and how are you envisioning this will be used, as the "type", "items", and "minItems" fields are not immediately applicable to, e.g., lilgui.

Notice how, for the other configurations, such as domainOpacity, the default value, along with min and max are directly applicable to a "slider" UI element.

In this case, I am not sure how the items and minItems fields have direct application to UI elements, but maybe you have a larger vision.

Yeh, they were placed from POV of JSON schema. They can be removed.

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

kgryte

LGTM

kgryte · 2026-05-05T22:07:40Z

As the CI failure is expected, I'll go ahead and merge.

feat: add route and menu support for axis domain-*

57a7f99

stdlib-bot added the Needs Review A pull request which needs code review. label Apr 30, 2026

kgryte added the Feature Issue or pull request for adding a new feature. label May 4, 2026

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/base/view/lib/browser/app/editor/config/axis.js Outdated

kgryte added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels May 4, 2026

gururaj1512 and others added 3 commits May 4, 2026 14:59

Merge branch 'refactor/plot' into view-axis-domain-_

5fa9759

fix: replace with inhouse dependency

21f2739

feat: rebuid bundle

b5be1cb

feat: add toNumberArray function for comma-separated integer parsing

9e6bf18

gururaj1512 requested a review from kgryte May 4, 2026 11:32

stdlib-bot added the Needs Review A pull request which needs code review. label May 4, 2026

Update default domainOpacity to 1

3845a3c

Changed the default domainOpacity value from 0 to 1. Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

kgryte removed Needs Changes Pull request which needs changes before being merged. Needs Review A pull request which needs code review. labels May 4, 2026

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/transforms.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

Apply suggestions from code review

9398de9

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

Apply suggestions from code review

32f7f2e

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

Apply suggestions from code review

3e20ca6

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

Apply suggestions from code review

f7c9ddc

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/axes/domain-dash/main.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/transforms.js Outdated

kgryte reviewed May 4, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/base/view/lib/browser/routes/config/transforms.js Outdated

Apply suggestions from code review

f4a37ae

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

kgryte added the Needs Discussion Needs further discussion. label May 4, 2026

Refine description of domainDash property

18425ee

Signed-off-by: Gururaj Gurram <143020143+gururaj1512@users.noreply.github.com>

gururaj1512 requested a review from kgryte May 5, 2026 21:14

stdlib-bot added the Needs Review A pull request which needs code review. label May 5, 2026

kgryte reviewed May 5, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

Apply suggestions from code review

bd81d4e

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

kgryte reviewed May 5, 2026

View reviewed changes

Comment thread lib/node_modules/@stdlib/plot/vega/editor-config/axis/lib/main.js Outdated

Apply suggestions from code review

444903c

Co-authored-by: Athan <kgryte@gmail.com> Signed-off-by: Athan <kgryte@gmail.com>

kgryte approved these changes May 5, 2026

View reviewed changes

kgryte merged commit c9056c3 into stdlib-js:refactor/plot May 5, 2026
9 of 11 checks passed

stdlib-bot removed the Needs Review A pull request which needs code review. label May 5, 2026

Uh oh!

Conversation

gururaj1512 commented Apr 30, 2026

Description

Related Issues

Questions

Other

Checklist

AI Assistance

Disclosure

Uh oh!

gururaj1512 commented Apr 30, 2026

Uh oh!

gururaj1512 commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kgryte commented May 4, 2026

Uh oh!

Uh oh!

kgryte commented May 4, 2026

Uh oh!

gururaj1512 commented May 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte May 4, 2026

Choose a reason for hiding this comment

Uh oh!

kgryte May 4, 2026

Choose a reason for hiding this comment

Uh oh!

kgryte May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgryte May 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gururaj1512 May 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kgryte left a comment

Choose a reason for hiding this comment

Uh oh!

kgryte commented May 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gururaj1512 commented May 1, 2026 •

edited

Loading

kgryte May 4, 2026 •

edited

Loading

kgryte May 4, 2026 •

edited

Loading